[
https://issues.apache.org/jira/browse/HDFS-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840589#comment-13840589
]
Hadoop QA commented on HDFS-5633:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12617211/HDFS-5633.000.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5646//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5646//console
This message is automatically generated.
> Improve OfflineImageViewer to use less memory
> ---------------------------------------------
>
> Key: HDFS-5633
> URL: https://issues.apache.org/jira/browse/HDFS-5633
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Priority: Minor
> Attachments: HDFS-5633.000.patch
>
>
> Currently after we rename a file/dir which is included in a snapshot, the
> file/dir can be linked with two different reference INodes. To avoid
> saving/loading the inode multiple times in/from FSImage, we use a temporary
> map to record whether we have visited this inode before.
> However, in OfflineImageViewer (specifically, in ImageLoaderCurrent), the
> current implementation simply records all the directory inodes. This can take
> a lot of memory when the fsimage is big. We should only record an inode in
> the temp map when it is referenced by an INodeReference, just like what we do
> in FSImageFormat.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
