[
https://issues.apache.org/jira/browse/HDFS-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841597#comment-13841597
]
Yongjun Zhang commented on HDFS-4983:
-------------------------------------
Many thanks to you all for the reviews and comments.
Hi Haohui,
Thanks for your detailed review. Some clarification here.
About the static block, the intention is that it always get executed when the
class is loaded, so to assure the default is initialized correctly.
I made the userPattern string static, and made it retrievable by the test code
(please refer to the change in TestParam.java), and annotated as
visibleForTesting.
About the property name, I think "webhdfs.....", meant to be consistent with
the counterpart "httpfs...". And this is what the original bug requested.
I made the public interface setUserPattern(Configuration) instead of
setUserPattern(String), so if in the future we want to set something
differently based on other configuration, we can just change inside UserParam
class without changing the caller.
Does that make sense to you?
Thanks.
--Yongjun
> Numeric usernames do not work with WebHDFS FS
> ---------------------------------------------
>
> Key: HDFS-4983
> URL: https://issues.apache.org/jira/browse/HDFS-4983
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: webhdfs
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Yongjun Zhang
> Labels: patch
> Attachments: HDFS-4983.001.patch, HDFS-4983.002.patch,
> HDFS-4983.003.patch, HDFS-4983.004.patch, HDFS-4983.005.patch
>
>
> Per the file
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserParam.java,
> the DOMAIN pattern is set to: {{^[A-Za-z_][A-Za-z0-9._-]*[$]?$}}.
> Given this, using a username such as "123" seems to fail for some reason
> (tried on insecure setup):
> {code}
> [123@host-1 ~]$ whoami
> 123
> [123@host-1 ~]$ hadoop fs -fs webhdfs://host-2.domain.com -ls /
> -ls: Invalid value: "123" does not belong to the domain
> ^[A-Za-z_][A-Za-z0-9._-]*[$]?$
> Usage: hadoop fs [generic options] -ls [-d] [-h] [-R] [<path> ...]
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
