[ 
https://issues.apache.org/jira/browse/HDFS-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843404#comment-13843404
 ] 

Chris Nauroth commented on HDFS-5642:
-------------------------------------

bq. I would prefer putting the Windows or Linux specific parts in separate 
files, rather than using #ifdefs, if possible.

I agree with this in principle, and I would have preferred this pattern in 
libhadoop.so/hadoop.dll too.  However, I seem to recall there was disagreement 
on this a while ago.  Does anyone else have an opinion?

bq. ...hash table...

Agreed that the details of this are open for consideration, rather than locked 
down on choosing uthash.  In fact, Stephen told me he encountered a compilation 
error in uthash on HP-UX, so perhaps it's not as cross-platform as we thought.


> libhdfs Windows compatibility.
> ------------------------------
>
>                 Key: HDFS-5642
>                 URL: https://issues.apache.org/jira/browse/HDFS-5642
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Chris Nauroth
>
> Currently, the libhdfs codebase does not compile on Windows due to use of 
> several Linux-specific functions, lack of build script support, and use of 
> C99 constructs.  The scope of this issue includes converting those function 
> calls to cross-platform equivalents (or use {{#ifdef}} if necessary), setting 
> up build support, and some code clean-ups to follow the C89 rules.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to