[ 
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HDFS-5594:
--------------------------------

    Attachment: HDFS-5594.6.patch

bq. Since you are touching FileSystem.java can clean following unused imports

Sure thing.  Here is patch version 6 to make that change.

bq. One more thing, (general), why cant we check of trailing space in modified 
lines using Hadoop QA? This is done in bookkeeper's QA.

I'm not sure if this is an enforced standard for the project, although it is 
something I strive to do in my patches.  I suggest filing a separate jira to do 
this, and if anyone objects, then they can discuss there.  It's definitely 
feasible to add a check for this in test-patch.sh.  It would need to be smart 
enough to detect trailing whitespace only on new code, not diff context from 
existing code.  i.e. something like:

{code}
grep '^\+.*\s$'
{code}


> FileSystem API for ACLs.
> ------------------------
>
>                 Key: HDFS-5594
>                 URL: https://issues.apache.org/jira/browse/HDFS-5594
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5594.1.patch, HDFS-5594.2.patch, HDFS-5594.3.patch, 
> HDFS-5594.4.patch, HDFS-5594.5.patch, HDFS-5594.6.patch
>
>
> Add new methods to {{FileSystem}} for manipulating ACLs.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to