[
https://issues.apache.org/jira/browse/HDFS-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850001#comment-13850001
]
Andrew Wang commented on HDFS-5634:
-----------------------------------
+1, thanks for all the revs Colin. If we find any more issues we can fix them
in post.
One last question, you can address it here or in the pending follow on:
{code}
} else if (buf.isDirect() && (needed > maxReadaheadLength)
{code}
Should this be {{needed >= maxReadaheadLength}} ?
> allow BlockReaderLocal to switch between checksumming and not
> -------------------------------------------------------------
>
> Key: HDFS-5634
> URL: https://issues.apache.org/jira/browse/HDFS-5634
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5634.001.patch, HDFS-5634.002.patch,
> HDFS-5634.003.patch, HDFS-5634.004.patch, HDFS-5634.005.patch,
> HDFS-5634.006.patch, HDFS-5634.007.patch
>
>
> BlockReaderLocal should be able to switch between checksumming and
> non-checksumming, so that when we get notifications that something is mlocked
> (see HDFS-5182), we can avoid checksumming when reading from that block.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
