[
https://issues.apache.org/jira/browse/HDFS-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854497#comment-13854497
]
Chris Nauroth commented on HDFS-5619:
-------------------------------------
This is another patch that will need a rebase, but aside from that it's looking
good. Here are a few comments:
# {{AclFeature#EMPTY_ENTRY_LIST}}: Should this be initialized with
{{Collections#emptyList}} so that it's impossible to accidentally add entries
to it?
# {{FSEditLogOp}}: I'm wondering if XML serialization of permissions ought to
use the {{FsAction#SYMBOL}} instead of the enum name. This would be consistent
with the presentation we have planned for the CLI and WebHDFS. What do you
think?
# {{TestFSImageWithAcl}}: It looks like {{folder}} is unused. Can we remove it?
# {{TestOfflineEditsViewer}}: I assume this test is breaking now with this
patch. We'll probably need changes in {{DFSTestUtil#runOperations}} and the
sample edits files checked into src/test/resources.
> NameNode: record ACL modifications to edit log.
> -----------------------------------------------
>
> Key: HDFS-5619
> URL: https://issues.apache.org/jira/browse/HDFS-5619
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Haohui Mai
> Attachments: HDFS-5619.000.patch
>
>
> Implement a new edit log opcode, {{OP_SET_ACL}}, which fully replaces the ACL
> of a specific inode. For ACL operations that perform partial modification of
> the ACL, the NameNode must merge the modifications with the existing ACL to
> produce the final resulting ACL and encode it into an {{OP_SET_ACL}}.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
