[ 
https://issues.apache.org/jira/browse/HDFS-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854525#comment-13854525
 ] 

Chris Nauroth commented on HDFS-5618:
-------------------------------------

I apologize for the redundancy on comments 3 and 5 above.  :-)

Haohui and I discussed point 2 offline and confirmed that the stream has a 
marker even for a null ACL.  For upgrades from prior layout versions, the 
current check is sufficient to handle it, so point 2 is resolved.  The new 
patch addresses all other points.

I ran a subset of HDFS tests with this patch, and I saw that 
{{TestOfflineEditsViewer}} and {{TestOfflineImageViewer}} failed.  Haohui, 
could you please investigate?  Thanks!

> NameNode: persist ACLs in fsimage.
> ----------------------------------
>
>                 Key: HDFS-5618
>                 URL: https://issues.apache.org/jira/browse/HDFS-5618
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Haohui Mai
>         Attachments: HDFS-5618.000.patch, HDFS-5618.001.patch
>
>
> Store ACLs in fsimage so that ACLs are retained across NameNode restarts.  
> This requires encoding and saving the {{AclManager}} state as a new section 
> of the fsimage, located after all existing sections (snapshot manager state, 
> inodes, secret manager state, and cache manager state).



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to