[
https://issues.apache.org/jira/browse/HDFS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857832#comment-13857832
]
Chris Nauroth commented on HDFS-5608:
-------------------------------------
[[email protected]] and [~renil.joseph], thank you for volunteering to
work on this.
Can you describe how this patch was generated? I can't seem to apply it to the
HDFS-4685 branch:
{code}
> patch -p0 < ~/patch/HDFS-5608.0.patch
patching file
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
patch: **** malformed patch at line 107: @@ -713,6 +747,10 @@
{code}
Since I couldn't apply it, I couldn't do a complete code review, but here are a
few comments to get started:
# {{AclPermissionParam}}: Is this a new class missing from the patch?
# {{NamenodeWebHdfsMethods}}: Note that the API has changed from GETACLS to
GETACLSTATUS, which returns the ACL of a single file or directory. This is
going to simplify WebHDFS a lot, because you won't need a {{StreamingOutput}}
to handle multiple items in a result set anymore. I recommend looking at the
new version of the design document (revision 2) that I uploaded to HDFS-4685
today.
# {{JsonUtil#toJsonString}}: The owner should be available on the {{AclStatus}}
object by now, so you can use that instead of the string "Test".
# {{JsonUtil#aclConvertion}}: Is this method name a typo? (Is it supposed to
be aclConversion?) There has been a design change in the JSON output so that
the ACL entries are much simpler. We're just going to put the string
representation of each ACL entry into a JSON array. Once again, this is
covered in the new revision of the design document.
# {{DFSConfigKeys#DFS_WEBHDFS_ACL_PERMISSION_PATTERN_DEFAULT}}: This appears to
be unused, unless it's used in the missing {{AclPermissionParam}}.
# {{FsAction}}: I expect you won't need to change this class anymore. I
committed HADOOP-10187 today, which added a similar helper method. If you sync
up to the latest code from the HDFS-4685 branch, you should see that method.
> WebHDFS: implement GETACLS and SETACL.
> --------------------------------------
>
> Key: HDFS-5608
> URL: https://issues.apache.org/jira/browse/HDFS-5608
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: webhdfs
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Sachin Jose
> Attachments: HDFS-5608.0.patch
>
>
> Implement and test {{GETACLS}} and {{SETACL}} in WebHDFS.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
