[
https://issues.apache.org/jira/browse/HDFS-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859418#comment-13859418
]
sathish commented on HDFS-5582:
-------------------------------
Thanks Andrew wang and Colin for having a look on the patch and i will follow
the code style as per your comments
> hdfs getconf -excludeFile or -includeFile always failed
> -------------------------------------------------------
>
> Key: HDFS-5582
> URL: https://issues.apache.org/jira/browse/HDFS-5582
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.1.0-beta, 2.2.0, 2.3.0
> Reporter: Henry Hung
> Assignee: sathish
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: 00001-HDFS-5582.patch, 0002-HDFS-5582.patch
>
>
> In hadoop-2.2.0, if you execute getconf for exclude and include file, it will
> return this error message:
> {code}
> [hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -excludeFile
> Configuration DFSConfigKeys.DFS_HOSTS_EXCLUDE is missing.
> [hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -includeFile
> Configuration DFSConfigKeys.DFS_HOSTS is missing.
> {code}
> I found out the root cause is very simple, it’s because the source code of
> {{org/apache/hadoop/hdfs/tools/GetConf.java}} hard coded it to
> {{"DFSConfigKeys.DFS_HOSTS"}} and {{"DFSConfigKeys.DFS_HOSTS_EXCLUDE"}}
> {code}
> map.put(INCLUDE_FILE.getName().toLowerCase(),
> new CommandHandler("DFSConfigKeys.DFS_HOSTS"));
> map.put(EXCLUDE_FILE.getName().toLowerCase(),
> new CommandHandler("DFSConfigKeys.DFS_HOSTS_EXCLUDE"));
> {code}
> A simple fix would be to remove the quote:
> {code}
> map.put(INCLUDE_FILE.getName().toLowerCase(),
> new CommandHandler(DFSConfigKeys.DFS_HOSTS));
> map.put(EXCLUDE_FILE.getName().toLowerCase(),
> new CommandHandler(DFSConfigKeys.DFS_HOSTS_EXCLUDE));
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
