[ 
https://issues.apache.org/jira/browse/HDFS-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867163#comment-13867163
 ] 

Hadoop QA commented on HDFS-5747:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12622242/HDFS-5747.01.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.web.TestHttpsFileSystem

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/5856//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5856//console

This message is automatically generated.

> BlocksMap.getStoredBlock(..) and 
> BlockInfoUnderConstruction.addReplicaIfNotPresent(..) may throw 
> NullPointerException
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5747
>                 URL: https://issues.apache.org/jira/browse/HDFS-5747
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-5747.01.patch
>
>
> Found these NPEs in [build 
> #5849|https://builds.apache.org/job/PreCommit-HDFS-Build/5849//testReport/org.apache.hadoop.hdfs/TestPersistBlocks/TestRestartDfsWithFlush/].
> - BlocksMap is accessed after close:
> {code}
> 2014-01-09 04:28:32,350 WARN  ipc.Server (Server.java:run(2060)) - IPC Server 
> handler 2 on 58333, call 
> org.apache.hadoop.hdfs.server.protocol.DatanodeProtocol.blockReceivedAndDeleted
>  from 127.0.0.1:55572 Call#32 Retry#0: error: java.lang.NullPointerException
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.getStoredBlock(BlocksMap.java:113)
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReportedBlock(BlockManager.java:1915)
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processAndHandleReportedBlock(BlockManager.java:2698)
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.addBlock(BlockManager.java:2685)
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processIncrementalBlockReport(BlockManager.java:2759)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.processIncrementalBlockReport(FSNamesystem.java:5321)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReceivedAndDeleted(NameNodeRpcServer.java:1018)
>       ...
> {code}
> - expectedLocation can be null.
> {code}
> 2014-01-09 04:28:35,384 WARN  ipc.Server (Server.java:run(2060)) - IPC Server 
> handler 5 on 58333, call 
> org.apache.hadoop.hdfs.server.protocol.DatanodeProtocol.blockReport from 
> 127.0.0.1:55583 Call#47 Retry#0: error: java.lang.NullPointerException
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoUnderConstruction.addReplicaIfNotPresent(BlockInfoUnderConstruction.java:331)
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processFirstBlockReport(BlockManager.java:1801)
>       at 
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReport(BlockManager.java:1645)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReport(NameNodeRpcServer.java:987)
>       ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to