[ 
https://issues.apache.org/jira/browse/HDFS-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867377#comment-13867377
 ] 

Hadoop QA commented on HDFS-5677:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12622277/HDFS-5677.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/5857//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5857//console

This message is automatically generated.

> Need error checking for HA cluster configuration
> ------------------------------------------------
>
>                 Key: HDFS-5677
>                 URL: https://issues.apache.org/jira/browse/HDFS-5677
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode, ha
>    Affects Versions: 2.0.6-alpha
>         Environment: centos6.5, oracle jdk6 45, 
>            Reporter: Vincent Sheffer
>            Assignee: Vincent Sheffer
>            Priority: Minor
>             Fix For: 3.0.0, 2.3.0
>
>         Attachments: HDFS-5677.patch
>
>
> If a node is declared in the *dfs.ha.namenodes.myCluster* but is _not_ later 
> defined in subsequent *dfs.namenode.servicerpc-address.myCluster.nodename* or 
> *dfs.namenode.rpc-address.myCluster.XXX* properties no error or warning 
> message is provided to indicate that.
> The only indication of a problem is a log message like the following:
> {code}
> WARN org.apache.hadoop.hdfs.server.datanode.DataNode: Problem connecting to 
> server: myCluster:8020
> {code}
> Another way to look at this is that no error or warning is provided when a 
> servicerpc-address/rpc-address property is defined for a node without a 
> corresponding node declared in *dfs.ha.namenodes.myCluster*.
> This arose when I had a typo in the *dfs.ha.namenodes.myCluster* property for 
> one of my node names.  It would be very helpful to have at least a warning 
> message on startup if there is a configuration problem like this.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to