[
https://issues.apache.org/jira/browse/HDFS-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870484#comment-13870484
]
Jing Zhao commented on HDFS-5738:
---------------------------------
The v4 patch looks great to me. One nit: we should use a different class for
the following code
{code}
private static final Log LOG = LogFactory
.getLog(DelegationTokenSecretManager.class);
{code}
Besides, the current digest computation can only be understood by the saver and
the loader. Maybe we should consider pulling the whole digest computation
process out of the FSImage saving/loading procedure, and do this computation
based on the complete FSImage file. But this can be discussed in a separate
jira.
> Serialize INode information in protobuf
> ---------------------------------------
>
> Key: HDFS-5738
> URL: https://issues.apache.org/jira/browse/HDFS-5738
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5738.000.patch, HDFS-5738.001.patch,
> HDFS-5738.002.patch, HDFS-5738.003.patch, HDFS-5738.004.patch
>
>
> This jira proposes to serialize inode information with protobuf.
> Snapshot-related information are out of the scope of this jira.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
