[ 
https://issues.apache.org/jira/browse/HDFS-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871377#comment-13871377
 ] 

Haohui Mai commented on HDFS-5772:
----------------------------------

The patch looks good to me.

{code}
+  message FileUnderConstructionEntry {
+    required uint64 file = 1;
+    required string fullPath = 2;
+  }
{code}

The protobuf fields should be optional, and it might make more sense to rename 
{{file}} intoto {{inodeId}}.

> Serialize under-construction file information in FSImage
> --------------------------------------------------------
>
>                 Key: HDFS-5772
>                 URL: https://issues.apache.org/jira/browse/HDFS-5772
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-5772.000.patch
>
>
> This jira defines FileUnderConstruction information in protobuf and adds 
> functionality to saving/loading the information.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to