[
https://issues.apache.org/jira/browse/HDFS-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871638#comment-13871638
]
Hadoop QA commented on HDFS-5768:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12623007/HDFS-5768.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5876//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5876//console
This message is automatically generated.
> Consolidate the serialization code in DelegationTokenSecretManager
> ------------------------------------------------------------------
>
> Key: HDFS-5768
> URL: https://issues.apache.org/jira/browse/HDFS-5768
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-5698 (FSImage in protobuf)
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5768.000.patch, HDFS-5768.001.patch
>
>
> This jira proposes to extract a private class for the serialization code for
> DelegationTokenSecretManager, so that it becomes easier to introduce new code
> paths to serialize the same set of information using protobuf.
> This jira does not intend to introduce any functionality changes.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
