[ 
https://issues.apache.org/jira/browse/HDFS-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871662#comment-13871662
 ] 

Hadoop QA commented on HDFS-5762:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12623043/HDFS-5762.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/5878//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5878//console

This message is automatically generated.

> BlockReaderLocal doesn't return -1 on EOF when doing zero-length reads
> ----------------------------------------------------------------------
>
>                 Key: HDFS-5762
>                 URL: https://issues.apache.org/jira/browse/HDFS-5762
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5762.001.patch, HDFS-5762.002.patch
>
>
> Unlike the other block readers, BlockReaderLocal currently doesn't return -1 
> on EOF when doing zero-length reads.  This behavior, in turn, propagates to 
> the DFSInputStream.  BlockReaderLocal should do this, so that client can 
> determine whether the file is at an end by doing a zero-length read and 
> checking for -1.
> One place this shows up is in libhdfs, which does such a 0-length read to 
> determine if direct (i.e., ByteBuffer) reads are supported.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to