[
https://issues.apache.org/jira/browse/HDFS-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872533#comment-13872533
]
Sachin Jose commented on HDFS-5608:
-----------------------------------
Thank you for the detailed review. Please review the updated patch, in this we
have addressed all of the above comments.
Still need to clarify 2 doubts
1. In ACL spec, other and mask AclTypes number of fileds should exactly 2, but
in the CLI implemenation it is accepting 3 fields as follows
eg:
Current implementation : mask::rw,other::rwx
expected - mask:rw,other:rwx
I'nk the current implementation can be changed to expected.
2. AclPermissionParam#parseAclSpec : For using common method for both the CLI
and WebHDFS, Where can we define the common method which be accessed from both
projects(hdfs,common). In the attached patch we copied the same implementation
from AclCommands#SetfaclCommand#parseAclSpec
> WebHDFS: implement GETACLSTATUS and SETACL.
> -------------------------------------------
>
> Key: HDFS-5608
> URL: https://issues.apache.org/jira/browse/HDFS-5608
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: webhdfs
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Sachin Jose
> Attachments: HDFS-5608.0.patch, HDFS-5608.1.patch, HDFS-5608.2.patch
>
>
> Implement and test {{GETACLS}} and {{SETACL}} in WebHDFS.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
