[ 
https://issues.apache.org/jira/browse/HDFS-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsuyoshi OZAWA updated HDFS-5167:
---------------------------------

    Attachment: HDFS-5167.10.patch

Thank you for reviewing, [~jingzhao]. Updated a patch based on your review 
comment:

1. Changed name of RetryCacheMetrics(added prefix "RetryCache:").
2. Added "if (LOG.isDebugEnabled())" in the constructor of RetryCacheMetrics.

I have a question about the your point 2. Currenty we need to setup HA use 
LossyRetryInvocationHandler. Do you have setting file to enable 
LossyRetryInvocationHandler?

{code}
      LOG.warn("Currently creating proxy using " +
                "LossyRetryInvocationHandler requires NN HA setup");
{code}



> Add metrics about the NameNode retry cache
> ------------------------------------------
>
>                 Key: HDFS-5167
>                 URL: https://issues.apache.org/jira/browse/HDFS-5167
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, namenode
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Jing Zhao
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: HDFS-5167.1.patch, HDFS-5167.10.patch, 
> HDFS-5167.2.patch, HDFS-5167.3.patch, HDFS-5167.4.patch, HDFS-5167.5.patch, 
> HDFS-5167.6.patch, HDFS-5167.6.patch, HDFS-5167.7.patch, HDFS-5167.8.patch, 
> HDFS-5167.9-2.patch, HDFS-5167.9.patch
>
>
> It will be helpful to have metrics in NameNode about the retry cache, such as 
> the retry count etc.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to