[
https://issues.apache.org/jira/browse/HDFS-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884810#comment-13884810
]
Chris Nauroth commented on HDFS-5771:
-------------------------------------
Hi, Haohui. A couple of notes:
# I see there are multiple sections that do {{beginStep}}/{{endStep}} for
{{StepType#INODES}}. Considering the way the {{StartupProgress}} class works,
the effect of this will be that progress jumps to 100% complete the first time
{{endStep}} gets called. After that, the subsequent calls to
{{beginStep}}/{{endStep}} are no-ops. Are all of the various inode sections
serialized sequentially in the new format? If so, then would it be possible to
do the {{beginStep}} call for {{StepType#INODES}} before the first inode
section, and then do the {{endStep}} after the last inode section?
# There is a similar situation with {{saveInodes}} and {{saveSnapshots}} trying
to begin/end the same step.
> Track progress when loading fsimage
> -----------------------------------
>
> Key: HDFS-5771
> URL: https://issues.apache.org/jira/browse/HDFS-5771
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-5698 (FSImage in protobuf)
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5771.000.patch, HDFS-5771.001.patch
>
>
> The old code that loads the fsimage tracks the progress during loading. This
> jira proposes to implement the same functionality in the new code which
> serializes the fsimage using protobuf..
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
