[
https://issues.apache.org/jira/browse/HDFS-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5858:
--------------------------------
Attachment: HDFS-5858.1.patch
This patch looks large, but it's all strictly refactoring of test code. Every
{{@Test}} formerly defined in {{TestNameNodeAcl}} has been pushed up into a new
abstract base class: {{FSAclBaseTest}}. {{TestNameNodeAcl}} is a subclass that
initializes the tests to run through an instance of {{DistributedFileSystem}}.
{{TestWebHDFSAcl}} is a subclass that initializes the tests to run through an
instance of {{WebHdfsFileSystem}}. All of the tests that had been duplicated
inside {{TestWebHDFS}} have been removed. (Basically, this is just taking
{{TestWebHDFS}} back to the trunk version.)
This patch is dependent on applying HDFS-5614 and HDFS-5849 first. Both of
those patches had added new test cases to {{TestNameNodeAcl}}. I intend to
commit both of those before this test refactoring.
> Refactor common ACL test cases to be run through multiple FileSystem
> implementations.
> -------------------------------------------------------------------------------------
>
> Key: HDFS-5858
> URL: https://issues.apache.org/jira/browse/HDFS-5858
> Project: Hadoop HDFS
> Issue Type: Test
> Components: namenode, test, webhdfs
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Attachments: HDFS-5858.1.patch
>
>
> HDFS-5608 implemented WebHDFS bindings for the new ACL APIs. As part of that
> patch, the test cases implemented in {{TestNameNodeAcl}} were duplicated to
> be run through {{WebHdfsFileSystem}}. Instead of duplicating, we can
> refactor so that the test cases are defined in a shared base class, and
> individual test suite subclasses initialize a different {{FileSystem}}
> implementation for those test cases to use.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
