[ 
https://issues.apache.org/jira/browse/HDFS-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HDFS-5614:
--------------------------------

    Attachment: HDFS-5614.3.patch

Thanks again, Jing.  Here is patch version 3.
# That's a good idea.  I filed HDFS-5860 as a separate issue for refactoring to 
use the common {{getFeature}} method.
# I removed the unnecessary assertion.
# I changed the {{INodeDirectory}} constructor like you suggested and updated 
its call sites.  One slightly messy aspect of this change is that I needed to 
add a public {{INodeWithAdditionalFields#getFeatures}} to expose the features 
array where protected access isn't applicable, like when a copy constructor 
needs to refer to a different instance, or the calling code is in the separate 
.snapshot sub-package.  If you have another idea on this part, let me know.

> NameNode: implement handling of ACLs in combination with snapshots.
> -------------------------------------------------------------------
>
>                 Key: HDFS-5614
>                 URL: https://issues.apache.org/jira/browse/HDFS-5614
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5614.1.patch, HDFS-5614.2.patch, HDFS-5614.3.patch
>
>
> Within a snapshot, all ACLs are frozen at the moment that the snapshot was 
> created.  ACL changes in the parent of the snapshot are not applied to the 
> snapshot.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to