[ 
https://issues.apache.org/jira/browse/HDFS-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888905#comment-13888905
 ] 

Hadoop QA commented on HDFS-5828:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12626306/HDFS-5828a.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6009//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6009//console

This message is automatically generated.

> BlockPlacementPolicyWithNodeGroup can place multiple replicas on the same 
> node group when dfs.namenode.avoid.write.stale.datanode is true
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5828
>                 URL: https://issues.apache.org/jira/browse/HDFS-5828
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.3.0
>            Reporter: Buddy
>         Attachments: HDFS-5828.patch, HDFS-5828a.patch
>
>
> When placing replicas using the replica placement policy 
> BlockPlacementPolicyWithNodeGroup, the number of targets returned should be 
> less than or equal to the number of node groups and no node group should get 
> two replicas of the same block. The Junit test 
> TestReplicationPolicyWithNodeGroup.testChooseMoreTargetsThanNodeGroups 
> verifies this.
> However, if the conf property "dfs.namenode.avoid.write.stale.datanode" is 
> set to true, then block placement policy will return more targets than node 
> groups when the number of replicas requested exceeds the number of node 
> groups.
> This can be seen by putting:
>        CONF.setBoolean(DFS_NAMENODE_AVOID_STALE_DATANODE_FOR_WRITE_KEY, true);
> in the setup method for TestReplicationPolicyWithNodeGroup. This will cause 
> testChooseMoreTargetsThanNodeGroups to fail.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to