[
https://issues.apache.org/jira/browse/HDFS-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889991#comment-13889991
]
Jing Zhao commented on HDFS-5871:
---------------------------------
The original code only writes "info.getExpiration().getMillis()" into fsimage,
while with the patch "info.getExpiration().isRelative()" will also be written.
Could you please make sure this is fine and comment why this is fine?
> Use PBHelper to serialize CacheDirectiveInfoExpirationProto
> -----------------------------------------------------------
>
> Key: HDFS-5871
> URL: https://issues.apache.org/jira/browse/HDFS-5871
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-5698 (FSImage in protobuf)
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5871.000.patch
>
>
> The current implementation of CacheManager serializes the
> CacheDirectiveInfoExpirationProto in-house. It should call PBHelper.convert()
> to avoid code duplication.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
