[ 
https://issues.apache.org/jira/browse/HDFS-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890987#comment-13890987
 ] 

Colin Patrick McCabe commented on HDFS-5810:
--------------------------------------------

Javadoc warnings come from using sun.misc.Unsafe, as I commented earlier.
{code}
10 warnings
[WARNING] Javadoc Warnings
[WARNING] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java:42:
 warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future 
release
[WARNING] import sun.misc.Unsafe;
{code}
Seems to be unavoidable.

Findbugs warning is also bogus.  It seems to be confused by having two "take 
lock, release on try/finally" blocks in the function instead of one.

TestHttpServer failure looks like HADOOP-10289.  It passed for me locally, and 
this patch doesn't affect the HttpServer.

> Unify mmap cache and short-circuit file descriptor cache
> --------------------------------------------------------
>
>                 Key: HDFS-5810
>                 URL: https://issues.apache.org/jira/browse/HDFS-5810
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>    Affects Versions: 2.3.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5810.001.patch, HDFS-5810.004.patch, 
> HDFS-5810.006.patch, HDFS-5810.008.patch, HDFS-5810.015.patch
>
>
> We should unify the client mmap cache and the client file descriptor cache.  
> Since mmaps are granted corresponding to file descriptors in the cache 
> (currently FileInputStreamCache), they have to be tracked together to do 
> "smarter" things like HDFS-5182.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to