[
https://issues.apache.org/jira/browse/HDFS-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891398#comment-13891398
]
Jing Zhao commented on HDFS-5885:
---------------------------------
According to protobuf document: "For historical reasons, repeated fields of
basic numeric types aren't encoded as efficiently as they could be. New code
should use the special option [packed=true] to get a more efficient encoding."
So I guess we only need to also add "[packed=true]" for basic numeric types
like int64? Do we want to also add it to "repeated BlockProto blocks"?
[~tlipcon], could you please comment on this?
> Add annotation for repeated fields in the protobuf definition
> -------------------------------------------------------------
>
> Key: HDFS-5885
> URL: https://issues.apache.org/jira/browse/HDFS-5885
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-5698 (FSImage in protobuf)
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5885.000.patch
>
>
> As suggested by the documentation of Protocol Buffers, the protobuf
> specification of the fsimage should specify [packed=true] for all repeated
> fields.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
