[
https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891587#comment-13891587
]
Andrew Wang commented on HDFS-5709:
-----------------------------------
Thanks ATM and Jing for reviewing this! I updated the docs, added command line
arg testing for upgrade, and also changed the LV name behavior.
Jing, right now I'm using the presence of the k/vs in the map to indicate that
the "-renameReserved" flag was passed at all, which is why I didn't statically
initialize the map with default values. I could switch it to use a boolean
instead, but (with ATM's suggestion) we now have the same default suffix for
all reserved paths, so adding a new default is as easy as putting it into the
new static array in HdfsConstants.
> Improve NameNode upgrade with existing reserved paths and path components
> -------------------------------------------------------------------------
>
> Key: HDFS-5709
> URL: https://issues.apache.org/jira/browse/HDFS-5709
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Labels: snapshots, upgrade
> Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch,
> hdfs-5709-4.patch, hdfs-5709-5.patch, hdfs-5709-6.patch, hdfs-5709-7.patch
>
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer
> to a directory named ".snapshot". We should at least print a better error
> message (which I believe was the original intention in HDFS-4666), and [~atm]
> proposed automatically renaming these files and directories.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
