[ 
https://issues.apache.org/jira/browse/HDFS-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896841#comment-13896841
 ] 

Jing Zhao commented on HDFS-5915:
---------------------------------

The patch looks pretty good to me. It will be better to have unit test for the 
new Loader/SaverContext. +1 after addressing the comment.

> Refactor FSImageFormatProtobuf to simplify cross section reads
> --------------------------------------------------------------
>
>                 Key: HDFS-5915
>                 URL: https://issues.apache.org/jira/browse/HDFS-5915
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5915.000.patch
>
>
> The PB-based FSImage puts the user name and the group name into a separate 
> section for deduplication. This jira refactor the code so that it is easier 
> to apply the same techniques for other types of data (e.g., 
> {{INodeReference}})



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to