[
https://issues.apache.org/jira/browse/HDFS-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897092#comment-13897092
]
Jing Zhao commented on HDFS-5920:
---------------------------------
Thanks for the comments Suresh!
bq. JournalNodeRpcServer#doRollingRollback is an empty method
Oops.. I forgot to put "jn.doRollingRollback(journalId, startTxId)" there...
The functionality has been included in the 000 patch except the call there.
bq. "their editlog starting at or above the given txid."
Here I want to mean ">=". I will update it to make it more clear.
bq. Instead of RollingRollbackRequest in QJournalProtocol, we may be able to
call it discardSegments?
Will rename it in the next patch.
> Support rollback of rolling upgrade in NameNode and JournalNodes
> ----------------------------------------------------------------
>
> Key: HDFS-5920
> URL: https://issues.apache.org/jira/browse/HDFS-5920
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: journal-node, namenode
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-5920.000.patch, HDFS-5920.000.patch
>
>
> This jira provides rollback functionality for NameNode and JournalNode in
> rolling upgrade.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
