[
https://issues.apache.org/jira/browse/HDFS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897116#comment-13897116
]
Chris Nauroth commented on HDFS-5914:
-------------------------------------
Sorry I missed the HDFS-5915 pre-requisite first time. A few minor comments:
# {{FSImageFormatPBINode}}: Symlinks don't get ACLs of their own. Shall we
skip serialization/deserialization of ACLs here for symlinks?
# {{TestAclConfigFlag#testFsImage}} is failing now, because it allowed loading
of an fsimage containing an ACL even though ACLs were disabled in
configuration. Previously, this was rejected by
{{FSImageFormat#loadAclFeature}} checking the config flag.
# {{FSImageFormatProtobuf}}: Minor typo: I think {{saveExtendAclSection}} was
meant to be named {{saveExtendedAclSection}}.
> Incorporate ACLs with the changes from HDFS-5698
> ------------------------------------------------
>
> Key: HDFS-5914
> URL: https://issues.apache.org/jira/browse/HDFS-5914
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode, security
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5914.000.patch
>
>
> HDFS-5698 uses protobuf to serialize the FSImage. The code needs to be
> updated to work with these changes.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
