[ 
https://issues.apache.org/jira/browse/HDFS-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898709#comment-13898709
 ] 

Colin Patrick McCabe commented on HDFS-5810:
--------------------------------------------

bq. ClientContext#confAsString has a dupe of socketCacheExpiry. Do we also need 
the mmap cache settings here?

will fix...

bq. The retry counting behavior is still not quite right. Because we set the 
remaining tries to -1 when we exhaust the domain peer cache, we won't ever try 
the TCP peer cache.

Good catch.  Will fix.

> Unify mmap cache and short-circuit file descriptor cache
> --------------------------------------------------------
>
>                 Key: HDFS-5810
>                 URL: https://issues.apache.org/jira/browse/HDFS-5810
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>    Affects Versions: 2.3.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5810.001.patch, HDFS-5810.004.patch, 
> HDFS-5810.006.patch, HDFS-5810.008.patch, HDFS-5810.015.patch, 
> HDFS-5810.016.patch, HDFS-5810.018.patch, HDFS-5810.019.patch, 
> HDFS-5810.020.patch
>
>
> We should unify the client mmap cache and the client file descriptor cache.  
> Since mmaps are granted corresponding to file descriptors in the cache 
> (currently FileInputStreamCache), they have to be tracked together to do 
> "smarter" things like HDFS-5182.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to