[ 
https://issues.apache.org/jira/browse/HDFS-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ding Yuan updated HDFS-5931:
----------------------------

    Attachment: hdfs-5931-v3.patch

A new patch fixing the test error. The reason hdfs-5931-v2.patch broke the test 
is that TestNNWithQJM#testMismatchedNNIsRejected() expects the exception 
message "Unable to start log segment 1: too few journals" thrown by 
FSEditLog.startLogSegment. Now this "too few journals" will be detected earlier 
by recoverUnclosedStreams, and therefore aborts earlier. This seems to be more 
reasonable as if we cannot even find enough journal in recoverUnclosedStreams, 
we should not proceed to startLogSegment and wait until then to reject this 
case.

> Potential bugs and improvements for exception handlers
> ------------------------------------------------------
>
>                 Key: HDFS-5931
>                 URL: https://issues.apache.org/jira/browse/HDFS-5931
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, namenode
>    Affects Versions: 2.2.0
>            Reporter: Ding Yuan
>         Attachments: hdfs-5931-v2.patch, hdfs-5931-v3.patch, hdfs-5931.patch
>
>
> This is to report some improvements and potential bug fixes to some error 
> handling code. Also attaching a patch for review.
> Details in the first comment.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to