[
https://issues.apache.org/jira/browse/HDFS-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900538#comment-13900538
]
Tsz Wo (Nicholas), SZE commented on HDFS-5945:
----------------------------------------------
> Since HDFS-5698 is already merged to trunk, why not merge those changes first
> and then make changes related to this jira using protobuf itself?
There are some conflicts with the branch. I plan to resolve them later on
since I have started to work on this.
> Instead of extracting checking part to checkUpgrade() can't we use
> nn.getFSImage().isUpgradeFinalized() directly? This will avoid checking disks
> on RPC calls holding writeLock.
You brought up a good point about the write lock. However,
isUpgradeFinalized() is different from checkUpgrade(), which is to check if
upgrade is started. Since starting rolling upgrade is an admin command, we can
safely assume that it won't be abused.
> Add rolling upgrade information to fsimage
> ------------------------------------------
>
> Key: HDFS-5945
> URL: https://issues.apache.org/jira/browse/HDFS-5945
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h5945_20140213.patch
>
>
> When rolling upgrade is in progress, the standby namenode may create
> checkpoint. The rolling upgrade information should be added to fsimage in
> order to support namenode restart and continue rolling upgrade.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
