[ 
https://issues.apache.org/jira/browse/HDFS-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901953#comment-13901953
 ] 

Yongjun Zhang commented on HDFS-3128:
-------------------------------------

+1. Thanks Andrew. Good fix! I went through the change, and I searched in the 
whole code base, just
to see if anything is missed, I didn't catch any. 

One thing I noticed is that, not because of your change,  there are lots of 
places in test area and one place not in test area (DBCountPageView.java) that 
hard-code the property string "test.build.data" . Probably we can consider 
adding a constant to common property file for this and replace them all with 
the constant as a future improvement. Thanks.



> TestResolveHdfsSymlink#testFcResolveAfs shouldn't use /tmp
> ----------------------------------------------------------
>
>                 Key: HDFS-3128
>                 URL: https://issues.apache.org/jira/browse/HDFS-3128
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.3.0
>            Reporter: Eli Collins
>            Assignee: Andrew Wang
>            Priority: Minor
>         Attachments: hdfs-3128-1.patch
>
>
> Saw this on jenkins, TestResolveHdfsSymlink#testFcResolveAfs creates 
> /tmp/alpha which interferes with other executors on the same machine.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to