[
https://issues.apache.org/jira/browse/HDFS-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906167#comment-13906167
]
stack commented on HDFS-5274:
-----------------------------
My guess is that the failures are unrelated. We can rerun the patch or just
wait on next iteration.
Patch looks great to me. Have you tried it outside of the unit tests to make
sure you get sensible looking spans and numbers? Perhaps I can help here?
Fix these in next patch:
"+ * This class do nothing If no SpanReceiver is configured ."
"+ * Trancing information of HTrace, if exists."
Is formatting ok here?
+ if (source != null) {
+ proto.setSource(PBHelper.convertDatanodeInfo(source));
+ }
+ send(out, Op.WRITE_BLOCK, proto.build());
+ } finally {
+ if (ts != null) ts.close();
+ }
In BlockReceiver, should traceSpan be getting closed?
Is it possible that below throws an exception?
+ scope.getSpan().addKVAnnotation(
+ "stream".getBytes(),
+ jas.getCurrentStream().toString().getBytes());
i..e. we can hope out w/o closing the span since the try/finally only happens
later.
This is in JournalSet in a few places.
TraceInfo and RPCTInfo seem to be same datastructure? Should we define it
onetime only and share?'
> Add Tracing to HDFS
> -------------------
>
> Key: HDFS-5274
> URL: https://issues.apache.org/jira/browse/HDFS-5274
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode, namenode
> Affects Versions: 2.1.1-beta
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HDFS-5274-0.patch, HDFS-5274-1.patch, HDFS-5274-2.patch,
> HDFS-5274-3.patch, HDFS-5274-4.patch, HDFS-5274-5.patch, HDFS-5274-6.patch,
> HDFS-5274-7.patch, Zipkin Trace a06e941b0172ec73.png, Zipkin Trace
> d0f0d66b8a258a69.png
>
>
> Since Google's Dapper paper has shown the benefits of tracing for a large
> distributed system, it seems like a good time to add tracing to HDFS. HBase
> has added tracing using HTrace. I propose that the same can be done within
> HDFS.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
