[
https://issues.apache.org/jira/browse/HDFS-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal resolved HDFS-5987.
---------------------------------
Resolution: Fixed
Fix Version/s: HDFS-5535 (Rolling upgrades)
Target Version/s: HDFS-5535 (Rolling upgrades)
Hadoop Flags: Reviewed
+1 for the patch.
Thanks for fixing these Nicholas!
> Fix findbugs warnings in Rolling Upgrade branch
> -----------------------------------------------
>
> Key: HDFS-5987
> URL: https://issues.apache.org/jira/browse/HDFS-5987
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, ha, hdfs-client, namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: HDFS-5535 (Rolling upgrades)
>
> Attachments: h5987_20140220.patch
>
>
> {noformat}
> RV
> org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceStorage.restoreBlockFilesFromTrash(File)
> ignores exceptional return value of java.io.File.mkdirs()
> RV
> org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceStorage.restoreBlockFilesFromTrash(File)
> ignores exceptional return value of java.io.File.renameTo(File)
> RV
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetAsyncDiskService$ReplicaFileDeleteTask.moveFiles()
> ignores exceptional return value of java.io.File.mkdirs()
> IS Inconsistent synchronization of
> org.apache.hadoop.hdfs.qjournal.server.Journal.committedTxnId; locked 92% of
> time
> NP Dereference of the result of readLine() without nullcheck in
> org.apache.hadoop.hdfs.util.MD5FileUtils.renameMD5File(File, File)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
