[
https://issues.apache.org/jira/browse/HDFS-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki updated HDFS-5274:
-----------------------------------
Attachment: ss-5274v8-get.png
ss-5274v8-put.png
HDFS-5274-8.patch
I am attaching updated patch and screen shots of trace of putting and getting a
200MB file.
bq. Fix these in next patch:
fixed.
bq. Is formatting ok here?
fixed.
bq. In BlockReceiver, should traceSpan be getting closed?
added description to span and calling close().
{quote}
Is it possible that below throws an exception?
+ scope.getSpan().addKVAnnotation(
+ "stream".getBytes(),
+ jas.getCurrentStream().toString().getBytes());
i..e. we can hope out w/o closing the span since the try/finally only happens
later.
This is in JournalSet in a few places.
{quote}
I moved these code in try block to make sure.
bq. TraceInfo and RPCTInfo seem to be same datastructure? Should we define it
onetime only and share?'
I prefer keeping this as is because of simplicity and independency between
datatransfer protocol and o.a.h.ipc.
bq. I checked the trace of putting and getting a big file by Zipkin today.
There seems to be too many spans concerning "DFSInputStream.read" and
"DFSOutputStream.write". I will fix this in the next version of patch.
just removed those spans from DFSInputStream and DFSOutputStream.
> Add Tracing to HDFS
> -------------------
>
> Key: HDFS-5274
> URL: https://issues.apache.org/jira/browse/HDFS-5274
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: datanode, namenode
> Affects Versions: 2.1.1-beta
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HDFS-5274-0.patch, HDFS-5274-1.patch, HDFS-5274-2.patch,
> HDFS-5274-3.patch, HDFS-5274-4.patch, HDFS-5274-5.patch, HDFS-5274-6.patch,
> HDFS-5274-7.patch, HDFS-5274-8.patch, Zipkin Trace a06e941b0172ec73.png,
> Zipkin Trace d0f0d66b8a258a69.png, ss-5274v8-get.png, ss-5274v8-put.png
>
>
> Since Google's Dapper paper has shown the benefits of tracing for a large
> distributed system, it seems like a good time to add tracing to HDFS. HBase
> has added tracing using HTrace. I propose that the same can be done within
> HDFS.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
