[
https://issues.apache.org/jira/browse/HDFS-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916600#comment-13916600
]
Colin Patrick McCabe commented on HDFS-5950:
--------------------------------------------
* I renamed {{DatanodeShmManager}} to {{EndpointShmManager}}. The original
name made it sound like it was on the DN side, which it is not.
* should take the {{ShortCircuitShm}} lock before modifying
{{DfsClientShm#stale}}, in case a {{BlockReaderFactory}} is concurrently
looking at that (the accessor was already synchronized)
* unregister the {{DfsClientShm}} from the {{DfsClientShmManager}} prior to
setting {{DfsClientShm#stale}}
* Add a {{Precondition}} in {{DfsClientShmManager#freeSlot}} that stale shms
are in neither {{full}} nor {{notFull}}
> The DFSClient and DataNode should use shared memory segments to communicate
> short-circuit information
> -----------------------------------------------------------------------------------------------------
>
> Key: HDFS-5950
> URL: https://issues.apache.org/jira/browse/HDFS-5950
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, hdfs-client
> Affects Versions: 2.4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5950.001.patch, HDFS-5950.003.patch,
> HDFS-5950.004.patch, HDFS-5950.006.patch, HDFS-5950.007.patch
>
>
> The DFSClient and DataNode should use the shared memory segments and unified
> cache added in the other HDFS-5182 subtasks to communicate short-circuit
> information.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
