[
https://issues.apache.org/jira/browse/HDFS-5866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916609#comment-13916609
]
Haohui Mai commented on HDFS-5866:
----------------------------------
The v4 patch looks mostly good.
{code}
+ return 1;
{code}
Let's return -1 instead of 1, since by convention a tool returns negative
status codes to indicate errors.
Nit: trailing whitespace.
{code}
int status = OfflineImageViewerPB.run(new String[] {"-i",
{code}
+1 once addressed.
> '-maxSize' and '-step' option fail in OfflineImageViewer
> --------------------------------------------------------
>
> Key: HDFS-5866
> URL: https://issues.apache.org/jira/browse/HDFS-5866
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: tools
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Akira AJISAKA
> Assignee: Akira AJISAKA
> Attachments: HDFS-5866.2.patch, HDFS-5866.3.patch, HDFS-5866.4.patch,
> HDFS-5866.patch
>
>
> Executing -step or/and -maxSize option will get the following error:
> {code}
> $ hdfs oiv -p FileDistribution -step 102400 -i input -o output
> Error parsing command-line options:
> Usage: bin/hdfs oiv [OPTIONS] -i INPUTFILE -o OUTPUTFILE
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
