[ 
https://issues.apache.org/jira/browse/HDFS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918959#comment-13918959
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-6038:
----------------------------------------------

BookKeeperJournalManager.startLogSegment(..) also has a hard coded 
NAMENODE_LAYOUT_VERSION.  We should update it.
{code}
// BookKeeperJournalManager.startLogSegment(..)
      EditLogLedgerMetadata l = new EditLogLedgerMetadata(znodePath,
          HdfsConstants.NAMENODE_LAYOUT_VERSION, currentLedger.getId(), txId);
{code}


> JournalNode hardcodes NameNodeLayoutVersion in the edit log file
> ----------------------------------------------------------------
>
>                 Key: HDFS-6038
>                 URL: https://issues.apache.org/jira/browse/HDFS-6038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, ha, hdfs-client, namenode
>            Reporter: Haohui Mai
>            Assignee: Jing Zhao
>         Attachments: HDFS-6038.000.patch, HDFS-6038.001.patch
>
>
> In HA setup, the JNs receive edit logs (blob) from the NN and write into edit 
> log files. In order to write well-formed edit log files, the JNs prepend a 
> header for each edit log file.
> The problem is that the JN hard-codes the version (i.e., 
> {{NameNodeLayoutVersion}} in the edit log, therefore it generates incorrect 
> edit logs when the newer release bumps the {{NameNodeLayoutVersion}} during 
> rolling upgrade.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to