[
https://issues.apache.org/jira/browse/HDFS-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924447#comment-13924447
]
Andrew Wang commented on HDFS-6071:
-----------------------------------
Looks generally good. Two review comments:
- Should remove WATERMELON prints
- The test only uses a normal ByteBuffer, not an allocateDirect one. Is this
hitting the fast lane in BRL?
Thanks Colin.
> BlockReaderLocal doesn't return -1 on EOF when doing a zero-length read on a
> short file
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-6071
> URL: https://issues.apache.org/jira/browse/HDFS-6071
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-6071.001.patch
>
>
> BlockReaderLocal doesn't return -1 on EOF when doing a zero-length read on a
> short file. Specifically, if the file is shorter than the readahead buffer,
> or if the position is nearer to the end than the length of the readahead
> buffer, this may happen. This is mainly a concern because libhdfs relies on
> this to determine whether it should use direct reads.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
