[
https://issues.apache.org/jira/browse/HDFS-6068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924611#comment-13924611
]
Andrew Wang commented on HDFS-6068:
-----------------------------------
I agree with Nicholas, I think we should just reuse the existing function. Also
note that the function you have right now is treating the snapshot name like a
path (splitting on "/" and checking each component), but in reality, the name
is just a single component.
Using this function means we'll start forbidding snapshots named {{.reserved}}
and {{.snapshot}}, but I think that's alright since allowing it seems prone to
weird bugs. Technically incompatible though.
> Disallow snapshot names that are also invalid directory names
> -------------------------------------------------------------
>
> Key: HDFS-6068
> URL: https://issues.apache.org/jira/browse/HDFS-6068
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 2.4.0
> Reporter: Andrew Wang
> Assignee: sathish
> Attachments: HDFS-6068-0001.patch, HDFS-6068-0002.patch
>
>
> There are a number of restrictions on valid names in HDFS. For example, you
> can't name a directory "." or "..", or something containing a ":".
> However, I can happily create a snapshot named "a:b:c", resulting in this:
> {code}
> -> % hdfs dfs -createSnapshot /home/andrew a:b:c
> Created snapshot /home/andrew/.snapshot/a:b:c
> -> % hadoop fs -ls /home/andrew/.snapshot
> -ls: java.net.URISyntaxException: Relative path in absolute URI: a:b:c
> Usage: hadoop fs [generic options] -ls [-d] [-h] [-R] [<path> ...]
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
