[
https://issues.apache.org/jira/browse/HDFS-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937624#comment-13937624
]
Hadoop QA commented on HDFS-6108:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12635041/HDFS-6108.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.datanode.TestCachingStrategy
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6411//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/6411//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6411//console
This message is automatically generated.
> make the length of the range in sync_file_range() configurable
> --------------------------------------------------------------
>
> Key: HDFS-6108
> URL: https://issues.apache.org/jira/browse/HDFS-6108
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Attachments: HDFS-6108.txt
>
>
> Current codebase has a hard code value for sync_file_range system call, we'd
> better to make it configurable, since different scenario probably has a
> different/better value for it. (ps: i found it's 1 * 1024 * 1024 in fb-20
> branch)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
