[
https://issues.apache.org/jira/browse/HDFS-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948342#comment-13948342
]
Colin Patrick McCabe commented on HDFS-6161:
--------------------------------------------
I think this is easy to fix just by changing the PB namespace that the QJournal
stuff is in. This doesn't alter what gets sent over the wire, and I think
(although I have not confirmed) that it won't alter the generated java code
much (or at all?).
> fix HDFS protobuf namespace conflicts
> -------------------------------------
>
> Key: HDFS-6161
> URL: https://issues.apache.org/jira/browse/HDFS-6161
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode, namenode
> Reporter: Colin Patrick McCabe
> Priority: Minor
>
> HDFS currently puts multiple protobuf definitions with the same name in the
> same protobuf namespace.
> For example, {{QJournalProtocol}} defines {{HeartbeatRequestProto}} in
> package {{hadoop.hdfs}}, but DatanodeProtocol also defines something
> different, also called {{HeartbeatRequestProto}} and also in package
> {{hadoop.hdfs}}.
> This isn't an issue in Java because the java PB compiler seems to disregard
> the PB namespaces, putting the generated {{QJournalProtocolProtos.java}} file
> in package {{org.apache.hadoop.hdfs.qjournal.protocol}} and the DN one in a
> different java namespace. However, it is an issue when creating protobuf
> bindings in other languages.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
