[
https://issues.apache.org/jira/browse/HDFS-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956739#comment-13956739
]
Aaron T. Myers commented on HDFS-5591:
--------------------------------------
Latest patch looks pretty good to me. One question:
{code}
+ + "\nLast Checkpoint : " + (lastCheckpointTime == 0? "--":
(lastCheckpointTime / 1000)) + " seconds ago"
{code}
Shouldn't this be something like "{{(lastCheckpointTime - Time.monotonicNow())
/ 1000}}? i.e. I think currently the value we're displaying is not actually the
"seconds ago" value.
Please let me know if I'm missing something. +1 once this is addressed.
> Checkpointing should use monotonic time when calculating period
> ---------------------------------------------------------------
>
> Key: HDFS-5591
> URL: https://issues.apache.org/jira/browse/HDFS-5591
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.2.0
> Reporter: Andrew Wang
> Assignee: Charles Lamb
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-5591.001.patch, HDFS-5591.002.patch,
> HDFS-5591.003.patch, HDFS-5591.004.patch
>
>
> Both StandbyCheckpointer and SecondaryNameNode use {{Time.now}} rather than
> {{Time.monotonicNow}} to calculate how long it's been since the last
> checkpoint. This can lead to issues when the system time is changed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
