[
https://issues.apache.org/jira/browse/HDFS-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957056#comment-13957056
]
Jing Zhao commented on HDFS-6167:
---------------------------------
The patch looks pretty good to me. Some minors:
# Do we want to provide getter methods for the public fields in DFSClient?
# It seems that ClientContext and PeerCache should stay in the hdfs package
since their usages are not that specific to short circuit read.
# Do we also want to move tests like TestShortCircuitCache,
TestShortCircuitShm, and TestShortCircuitLocalRead to the shortcircuit package?
> Relocate the non-public API classes in the hdfs.client package
> --------------------------------------------------------------
>
> Key: HDFS-6167
> URL: https://issues.apache.org/jira/browse/HDFS-6167
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h6167_20140327.patch, h6167_20140327.patch,
> h6167_20140327svn_mv.patch, h6167_20140328.patch, h6167_20140328svn_mv.patch,
> svn_mv.sh
>
>
> The org.apache.hadoop.hdfs.client package is for public client API. The
> non-public API classes should be moved to some other packages.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
