[ 
https://issues.apache.org/jira/browse/HDFS-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957914#comment-13957914
 ] 

Brandon Li edited comment on HDFS-6181 at 4/2/14 5:30 PM:
----------------------------------------------------------

[~szetszwo], usually we use the same name for the variable and its value, but 
looks like we are not consistent in DFSConfigKeys.java, for example: 
DFS_DATANODE_USER_NAME_KEY, DFS_NAMENODE_USER_NAME_KEY and etc.  Not sure why 
these variables were named differently with their values. In one place, we are 
consistent:
DFS_WEB_AUTHENTICATION_KERBEROS_PRINCIPAL_KEY = 
"dfs.web.authentication.kerberos.principal";

If we don't have a good reason to name the variables differently, I can update 
all of the following to make the name the same as value:
DFS_NAMENODE_USER_NAME_KEY, DFS_DATANODE_USER_NAME_KEY, 
DFS_JOURNALNODE_USER_NAME_KEY, DFS_SECONDARY_NAMENODE_USER_NAME_KEY,  
DFS_NFS_USER_NAME_KEY


was (Author: brandonli):
[~szetszwo], usually we use the same name for the variable and its value, but 
looks like we are not consistent in DFSConfigKeys.java, for example: 
DFS_DATANODE_USER_NAME_KEY, DFS_NAMENODE_USER_NAME_KEY and etc.  Not sure why 
these variables were named differently with their values. In one place, we are 
consistent:
DFS_WEB_AUTHENTICATION_KERBEROS_PRINCIPAL_KEY = 
"dfs.web.authentication.kerberos.principal";

If we don't have a good reason to name the variables differently, I can update 
all of the following to make the name the same as value:
DFS_NAMENODE_USER_NAME_KEY, DFS_DATANODE_USER_NAME_KEY, 
DFS_JOURNALNODE_USER_NAME_KEY, DFS_SECONDARY_NAMENODE_USER_NAME_KEY,  
DFS_NFS_USER_NAME_KEY

Note, 

> Fix the wrong property names in NFS user guide
> ----------------------------------------------
>
>                 Key: HDFS-6181
>                 URL: https://issues.apache.org/jira/browse/HDFS-6181
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: documentation, nfs
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Trivial
>         Attachments: HDFS-6181.patch
>
>
> A couple property names are wrong in the NFS user guide, and should be fixed 
> as the following:
> {noformat}
>  <property>
> -  <name>dfs.nfsgateway.keytab.file</name>
> +  <name>dfs.nfs.keytab.file</name>
>    <value>/etc/hadoop/conf/nfsserver.keytab</value> <!-- path to the nfs 
> gateway keytab -->
>  </property>
>  <property>
> -  <name>dfs.nfsgateway.kerberos.principal</name>
> +  <name>dfs.nfs.kerberos.principal</name>
>    <value>nfsserver/[email protected]</value>
>  </property>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to