[ 
https://issues.apache.org/jira/browse/HDFS-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962228#comment-13962228
 ] 

Hadoop QA commented on HDFS-6197:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12639026/HDFS-6197.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestDistributedFileSystem
                  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6603//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6603//console

This message is automatically generated.

> Rolling upgrade rollback on Windows can fail attempting to rename edit log 
> segment files to a destination that already exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6197
>                 URL: https://issues.apache.org/jira/browse/HDFS-6197
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>         Attachments: HDFS-6197.1.patch
>
>
> As part of a rollback from a rolling upgrade in progress, we discard edit log 
> segments by renaming the file with suffix ".trash".  If no new edits arrive 
> in between multiple attempts, then the ".trash" file may still exist.  On 
> Windows, {{java.io.File#renameTo}} fails if the destination already exists 
> though.  This is visible right now as a failure in 
> {{TestRollingUpgrade#testRollback}} when running on Windows.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to