[ 
https://issues.apache.org/jira/browse/HDFS-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HDFS-6197:
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4.1
                   3.0.0
           Status: Resolved  (was: Patch Available)

I committed this to trunk, branch-2 and branch-2.4.  Nicholas and Jing, thank 
you for the code reviews.

> Rolling upgrade rollback on Windows can fail attempting to rename edit log 
> segment files to a destination that already exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6197
>                 URL: https://issues.apache.org/jira/browse/HDFS-6197
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>             Fix For: 3.0.0, 2.4.1
>
>         Attachments: HDFS-6197.1.patch
>
>
> As part of a rollback from a rolling upgrade in progress, we discard edit log 
> segments by renaming the file with suffix ".trash".  If no new edits arrive 
> in between multiple attempts, then the ".trash" file may still exist.  On 
> Windows, {{java.io.File#renameTo}} fails if the destination already exists 
> though.  This is visible right now as a failure in 
> {{TestRollingUpgrade#testRollback}} when running on Windows.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to