[
https://issues.apache.org/jira/browse/HDFS-6224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965603#comment-13965603
]
Andrew Wang commented on HDFS-6224:
-----------------------------------
Hey Charles, I took a quick look at the patch, and it seems like it's just
checking that it logs twice, but not the actual content of the audit log
messages. Shouldn't we be verifying that too? It'd also be good to have a more
descriptive comment than "Tests that AuditLogger works as expected."
> Add a unit test to TestAuditLogger for file permissions passed to
> logAuditEvent
> -------------------------------------------------------------------------------
>
> Key: HDFS-6224
> URL: https://issues.apache.org/jira/browse/HDFS-6224
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Reporter: Charles Lamb
> Assignee: Andrew Wang
> Priority: Minor
> Attachments: HDFS-6224.001.patch
>
>
> Add a unit test which verifies behavior of HADOOP-9155. Specifically, ensure
> that during a setPermission operation the permission returned is the one that
> was just set, not the permission before the operation.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
