[
https://issues.apache.org/jira/browse/HDFS-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965632#comment-13965632
]
Hadoop QA commented on HDFS-5669:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639615/HDFS-5669.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6642//console
This message is automatically generated.
> Storage#tryLock() should check for null before logging successfull message
> --------------------------------------------------------------------------
>
> Key: HDFS-5669
> URL: https://issues.apache.org/jira/browse/HDFS-5669
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.2.0
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HDFS-5669.patch, HDFS-5669.patch
>
>
> In the following code in Storage#tryLock(), there is a possibility that
> {{file.getChannel().tryLock()}} returns null if the lock is acquired by some
> other process. In that case even though return value is null, a successfull
> message confuses.
> {code}try {
> res = file.getChannel().tryLock();
> file.write(jvmName.getBytes(Charsets.UTF_8));
> LOG.info("Lock on " + lockF + " acquired by nodename " + jvmName);
> } catch(OverlappingFileLockException oe) {{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
