[ 
https://issues.apache.org/jira/browse/HDFS-6236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967367#comment-13967367
 ] 

Hadoop QA commented on HDFS-6236:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12639894/HDFS-6236.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6655//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6655//console

This message is automatically generated.

> ImageServlet should use Time#monotonicNow to measure latency.
> -------------------------------------------------------------
>
>                 Key: HDFS-6236
>                 URL: https://issues.apache.org/jira/browse/HDFS-6236
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>         Attachments: HDFS-6236.1.patch
>
>
> {{ImageServlet}} currently uses {{Time#now}} to get file transfer latency 
> measurements and pass them to the metrics system.  It would be preferrable to 
> use {{Time#monotonicNow}} so that we're using the most precise available 
> system timer, and we're not subject to odd bugs that could result in negative 
> latency measurements, like resetting the system clock.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to